Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed grammar, spelling, in README in a few places #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed grammar, spelling, in README in a few places #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f84f11
Fixed grammar, spelling, in README in a few places
Jun 12, 2017
d006aeb
fixed stray (duplicate?) function definition that was breaking everyt…
Jun 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# omxplayer-controll

Controll omxplayer with native dbus
Control omxplayer with native dbus


## Installation
Expand All @@ -13,7 +13,7 @@ npm install omxplayer-controll [--save]
## Usage


Short example running a video getting the status every 5 seconds and listeing to the aboutToFinis signal
Short example running a video getting the status every 5 seconds and listening to the aboutToFinish signal

```js
var omxp = require('omxplayer-controll');
Expand Down Expand Up @@ -68,19 +68,19 @@ omxp.setAspectMode(function(err){});
```

### Other commands
Change de Alpha of the current window the value must be between 0 and 255
Change the Alpha of the current window the value; must be between 0 and 255
```js
omxp.setAlpha(alpha_value, function(err){});
```
Set the position of the window, only works in non full screen.
Set the position of the window; only works in non full screen.
```js
omxp.setVideoPos(x1, y1, x2, y2, function(err){});
```
Crop the video inside the window.
```js
omxp.setVideoCropPos(x1, y1, x2, y2, function(err){});
```
Set the aspect mode for the video, must be one of the following:
Set the aspect mode for the video; must be one of the following:
'letterbox', 'fill', 'stretch', 'default'
```js
omxp.setAspectMode(aspect, function(err){});
Expand Down
14 changes: 7 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,13 +162,13 @@ module.exports.previousSubtitle = function(cb) { //checked
return typeof cb === 'function' ? cb(err) : {};
});
};
module.exports.hideSubtitles = function(cb) { //checked not tested (I have no subtitles)
omx_dbus.method('Action', [30], function(err) {
module.exports.previousSubtitle = function(cb) { //checked
omx_dbus.method('Action', [10], function(err) {
return typeof cb === 'function' ? cb(err) : {};
});
};
// module.exports.hideSubtitles = function(cb) { //checked not tested (I have no subtitles)
// omx_dbus.method('Action', [30], function(err) {
// module.exports.previousSubtitle = function(cb) { //checked
// omx_dbus.method('Action', [10], function(err) {
// return typeof cb === 'function' ? cb(err) : {};
// });
// };
module.exports.hideSubtitles = function(cb) { //checked not tested (I have no subtitles)
omx_dbus.method('Action', [30], function(err) {
return typeof cb === 'function' ? cb(err) : {};
Expand Down