Fix wrong satellite miss detection

[lars18th]

In some NIT tables the orbital position has a negative value. This patch solves it and it adds more useful information in the log message "WRONG SATELLITE".

[lars18th]

This is related to wirbel-at-vdr-portal/w_scan_cpp#22 (comment)

[wirbel-at-vdr-portal]

No, this one is a wrong change.

Instead, it should be fixed at the source of the problem.
Send me a full log with four time '-v' for the problematic satellite. Will be a few megs.
I need to the read the nit tables send on this sat from the log.

[wirbel-at-vdr-portal]

May be you could check

scanfilter.cpp:840

-- if (!sd->getWestEastFlag())
-- transponder->OrbitalPos *= -1;
++ transponder->West = west_flag;

[lars18th]

Hi @wirbel-at-vdr-portal ,

May be you could check

Yes. I was thinking about something similar today. So please be on hold. I'll update this PR.

[lars18th]

Hi @wirbel-at-vdr-portal ,

I've updated the PR. With your suggestion I don't have detected any trouble scanning 30W. I suggest to test it.

Regards.

[wirbel-at-vdr-portal]

So, the problem as such is gone. We're close to merge it, solution is nice. Just finishing it.

However, i would like to debug print (only) the wrong satellite's position, something like S30W0 or similar. Just in case, this one pops up later again and i don't understand it reading megabytes of looong log files.

Any idea, or you want me to step in (may take some time unfortunally, beeing busy for a few weeks).

[lars18th]

Hi @wirbel-at-vdr-portal ,

Please take as much time as you need to test and merge this correction. As the solution is uncomplicated, it's preferable to wait until everything is properly tested. I always prefer a good, well-tested software rather than making quick changes.