test(ffi): ensure that errors raised in core-crypto produce logs [WPB…

…-14355]

crypto-ffi/Cargo.toml

@@ -18,7 +18,12 @@ required-features = ["uniffi/cli"]
 
 [features]
 default = ["proteus"]
-proteus = ["core-crypto/proteus", "core-crypto/cryptobox-migrate", "dep:proteus-wasm", "dep:core-crypto-keystore"]
+proteus = [
+    "core-crypto/proteus",
+    "core-crypto/cryptobox-migrate",
+    "dep:proteus-wasm",
+    "dep:core-crypto-keystore",
+]
 
 [dependencies]
 thiserror.workspace = true
@@ -32,7 +37,7 @@ log-reload.workspace = true
 serde_json.workspace = true
 derive_more.workspace = true
 proteus-wasm = { workspace = true, optional = true }
-core-crypto-keystore = { workspace = true, optional = true}
+core-crypto-keystore = { workspace = true, optional = true }
 
 # see https://github.com/RustCrypto/hashes/issues/404
 [target.'cfg(not(any(target_arch = "aarch64", target_arch = "x86_64", target_arch = "x86")))'.dependencies]
@@ -69,7 +74,18 @@ wasm-bindgen-test = "0.3"
 wasm-opt = false
 
 [package.metadata.wasm-pack.profile.release]
-wasm-opt = ["-Os", "--enable-mutable-globals", "--enable-threads", "--detect-features"]
+wasm-opt = [
+    "-Os",
+    "--enable-mutable-globals",
+    "--enable-threads",
+    "--detect-features",
+]
 
 [lints.rust]
-unexpected_cfgs = { level = "warn", check-cfg = ['cfg(wasm_bindgen_unstable_test_coverage)'] }
+unexpected_cfgs = { level = "warn", check-cfg = [
+    'cfg(wasm_bindgen_unstable_test_coverage)',
+] }
+
+[dev-dependencies]
+testing_logger = "0.1.1"
+tokio = { version = "1.43.0", default-features = false, features = ["macros", "rt"] }

crypto-ffi/src/generic/mod.rs

@@ -2376,4 +2376,24 @@ mod tests {
             CoreCryptoError::Mls(MlsError::ConversationAlreadyExists(_))
         ));
     }
+
+    #[tokio::test]
+    async fn test_error_is_logged() {
+        testing_logger::setup();
+        // we shouldn't be able to create a SQLite DB in `/root` unless we are running this test as root
+        // Don't do that!
+        let result = CoreCrypto::new("/root/asdf".into(), "key".into(), None, None, None).await;
+        assert!(
+            result.is_err(),
+            "result must be an error in order to verify that something was logged"
+        );
+        testing_logger::validate(|captured_logs| {
+            assert!(
+                captured_logs.iter().any(|log| log.level == Level::Warn
+                    && log.target == "core-crypto"
+                    && log.body.contains("returning this error across ffi")),
+                "log message did not appear within the captured logs"
+            )
+        });
+    }
 }