Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update tls_codec requirement from 0.3.0 to 0.4.0 #435

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 22, 2023

Updates the requirements on tls_codec to permit the latest version.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 22, 2023
@beltram beltram force-pushed the dependabot/cargo/tls_codec-0.4.0 branch from c05e46c to 4b72dd0 Compare November 27, 2023 08:44
@beltram beltram requested a review from OtaK November 27, 2023 16:23
Copy link
Contributor

@OtaK OtaK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tls_deserialize_exact should not be used outside of testing. It is designed for single-entity payloads and will break if there's even an extra byte.

@beltram beltram force-pushed the dependabot/cargo/tls_codec-0.4.0 branch from fb36edc to 6279279 Compare November 28, 2023 14:09
@beltram beltram requested a review from OtaK November 28, 2023 14:10
Updates the requirements on [tls_codec](https://github.com/RustCrypto/formats) to permit the latest version.
- [Commits](RustCrypto/formats@tls_codec/v0.3.0...tls_codec/v0.3.0)

---
updated-dependencies:
- dependency-name: tls_codec
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@beltram beltram force-pushed the dependabot/cargo/tls_codec-0.4.0 branch from 6279279 to 68c92de Compare November 28, 2023 14:24
@codecov-commenter
Copy link

Codecov Report

Merging #435 (68c92de) into develop (d145775) will decrease coverage by 0.04%.
Report is 2 commits behind head on develop.
The diff coverage is 82.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #435      +/-   ##
===========================================
- Coverage    74.14%   74.10%   -0.04%     
===========================================
  Files           90       90              
  Lines        16301    16304       +3     
===========================================
- Hits         12086    12082       -4     
- Misses        4215     4222       +7     
Files Coverage Δ
crypto/src/e2e_identity/identity.rs 88.05% <100.00%> (ø)
crypto/src/e2e_identity/mod.rs 98.76% <100.00%> (+0.03%) ⬆️
crypto/src/e2e_identity/rotate.rs 84.40% <100.00%> (-0.21%) ⬇️
crypto/src/e2e_identity/stash.rs 93.18% <100.00%> (+0.24%) ⬆️
crypto/src/mls/client/key_package.rs 90.22% <100.00%> (ø)
crypto/src/mls/conversation/buffer_messages.rs 87.44% <100.00%> (ø)
crypto/src/mls/conversation/decrypt.rs 69.45% <100.00%> (ø)
crypto/src/mls/conversation/group_info.rs 69.69% <100.00%> (ø)
crypto/src/mls/conversation/self_commit.rs 90.07% <100.00%> (ø)
crypto/src/mls/credential/ext.rs 60.00% <100.00%> (ø)
... and 7 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac6b87e...68c92de. Read the comment docs.

Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 28, 2023

A newer version of tls_codec exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@beltram beltram merged commit 04df2df into develop Nov 28, 2023
21 checks passed
@beltram beltram deleted the dependabot/cargo/tls_codec-0.4.0 branch November 28, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants