Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(e2ei): add handle & team to dpop challenge #436

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

beltram
Copy link
Contributor

@beltram beltram commented Nov 23, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2023

Codecov Report

Merging #436 (39b8e4d) into develop (d145775) will decrease coverage by 0.02%.
The diff coverage is 86.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #436      +/-   ##
===========================================
- Coverage    74.14%   74.12%   -0.02%     
===========================================
  Files           90       90              
  Lines        16301    16315      +14     
===========================================
+ Hits         12086    12094       +8     
- Misses        4215     4221       +6     
Files Coverage Δ
crypto/src/e2e_identity/identity.rs 88.05% <100.00%> (ø)
crypto/src/e2e_identity/mod.rs 98.76% <100.00%> (+0.03%) ⬆️
crypto/src/e2e_identity/rotate.rs 84.40% <100.00%> (-0.21%) ⬇️
crypto/src/e2e_identity/stash.rs 93.18% <100.00%> (+0.24%) ⬆️
crypto/src/mls/conversation/self_commit.rs 90.07% <100.00%> (ø)
crypto/src/test_utils/central.rs 84.16% <100.00%> (+0.03%) ⬆️
crypto-ffi/src/generic.rs 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d145775...39b8e4d. Read the comment docs.

@beltram beltram requested a review from OtaK November 24, 2023 11:28
@OtaK OtaK added the enhancement New feature or request label Nov 28, 2023
@OtaK OtaK added this to the 1.0.0 milestone Nov 28, 2023
@OtaK OtaK added the api:breaking This contains breaking changes to the public-facing API label Nov 28, 2023
@OtaK OtaK changed the title feat(e2ei): add handle & team to dpop challenge feat!(e2ei): add handle & team to dpop challenge Nov 28, 2023
@OtaK
Copy link
Contributor

OtaK commented Nov 28, 2023

Rebase & squash "wip" commits needed

@beltram beltram force-pushed the feat/dpop-handle-team branch from 39b8e4d to fcdbc2e Compare November 28, 2023 14:16
@beltram beltram merged commit ac6b87e into develop Nov 28, 2023
2 of 13 checks passed
@beltram beltram deleted the feat/dpop-handle-team branch November 28, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:breaking This contains breaking changes to the public-facing API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants