Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Swift wrapper for E2eiEnrollment was not used in other methods #454

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: Swift wrapper for E2eiEnrollment was not used in other methods #454

merged 1 commit into from
Dec 18, 2023

Conversation

beltram
Copy link
Contributor

@beltram beltram commented Dec 18, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram requested a review from David-Henner December 18, 2023 12:53
@beltram beltram merged commit a7ff1d1 into develop Dec 18, 2023
21 checks passed
@beltram beltram deleted the fix/e2ei-swift-enrollment branch December 18, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Henner David-Henner David-Henner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beltram @David-Henner