Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ClientId & Handle are URIs #460

Merged
merged 1 commit into from
Jan 10, 2024
Merged

feat: ClientId & Handle are URIs #460

merged 1 commit into from
Jan 10, 2024

Conversation

beltram
Copy link
Contributor

@beltram beltram commented Jan 3, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@beltram beltram force-pushed the feat/clientid-uri branch from 05efc6d to ec6a11d Compare January 3, 2024 16:11
@beltram beltram self-assigned this Jan 3, 2024
@beltram beltram requested a review from OtaK January 3, 2024 16:13
@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be4edd4) 73.04% compared to head (8155c9c) 73.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #460      +/-   ##
===========================================
- Coverage    73.04%   73.00%   -0.04%     
===========================================
  Files           91       91              
  Lines        15060    15086      +26     
===========================================
+ Hits         11000    11014      +14     
- Misses        4060     4072      +12     
Files Coverage Δ
crypto/src/e2e_identity/mod.rs 98.61% <100.00%> (ø)
crypto/src/e2e_identity/rotate.rs 84.62% <100.00%> (ø)
crypto/src/mls/client/user_id.rs 90.47% <ø> (ø)
crypto/src/test_utils/central.rs 82.53% <100.00%> (ø)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4edd4...8155c9c. Read the comment docs.

@beltram beltram force-pushed the feat/clientid-uri branch from a0535ca to 8155c9c Compare January 5, 2024 15:06
@beltram beltram merged commit ab62648 into develop Jan 10, 2024
22 checks passed
@beltram beltram deleted the feat/clientid-uri branch January 10, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants