Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move version function to module [WPB-15329] #867

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

typfel
Copy link
Member

@typfel typfel commented Jan 20, 2025

What's new in this PR

Move the version() from the CoreCrypto instance to the module level.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel typfel requested a review from a team as a code owner January 20, 2025 14:47
Copy link

github-actions bot commented Jan 20, 2025

🐰 Bencher Report

Branchrefactor/move-version-to-module-WPB-15329
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.82
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.93
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.48
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.06
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
15.34
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.88
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
993.40
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
7.09
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
86.00
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
223.33
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
431.23
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
680.49
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
116.82
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.53
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
46.12
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
61.25
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.67
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
95.70
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
19.29
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
115.83
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.85
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.98
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.83
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
96.13
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
28.82
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7.10
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.09
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.44
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.83
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22.51
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30.68
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.81
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.44
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
94.38
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
73.09
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
51.83
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
137.76
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7.19
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.77
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.17
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86.97
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
112.01
🐰 View full continuous benchmarking report in Bencher

@istankovic
Copy link
Member

The first commit's message is missing a colon and space (: ) after refactor(web).

@typfel typfel force-pushed the refactor/move-version-to-module-WPB-15329 branch from 7fe0d84 to 72859fa Compare January 20, 2025 15:34
@typfel typfel force-pushed the refactor/move-version-to-module-WPB-15329 branch from 72859fa to 9fd4c5a Compare January 21, 2025 13:58
@typfel typfel merged commit 9fd4c5a into main Jan 21, 2025
9 checks passed
@typfel typfel deleted the refactor/move-version-to-module-WPB-15329 branch January 21, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants