Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enforce signed tags #874

Merged
merged 1 commit into from
Jan 22, 2025
Merged

ci: enforce signed tags #874

merged 1 commit into from
Jan 22, 2025

Conversation

istankovic
Copy link
Member

Make sure every tag has a signature. Note that we intentionally do not verify the signature, similarly for commits.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@istankovic istankovic requested a review from a team as a code owner January 21, 2025 16:37
Copy link

github-actions bot commented Jan 21, 2025

🐰 Bencher Report

Branchivan/enforce-signed-tags
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.53
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.83
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.42
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.74
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14.77
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.66
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
982.92
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.84
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84.81
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
220.32
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
425.12
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
674.21
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115.59
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.43
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45.82
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.59
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.19
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
93.85
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18.57
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
114.95
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.53
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.27
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.15
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
94.90
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
28.08
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.76
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8.92
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.03
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
16.96
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
21.62
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
30.01
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.40
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
114.94
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.85
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71.80
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50.31
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
136.99
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
7.01
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.49
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.59
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86.76
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
111.94
🐰 View full continuous benchmarking report in Bencher

@istankovic istankovic force-pushed the ivan/enforce-signed-tags branch from 942e926 to db17a57 Compare January 22, 2025 11:18
@istankovic istankovic merged commit db17a57 into main Jan 22, 2025
38 checks passed
@istankovic istankovic deleted the ivan/enforce-signed-tags branch January 22, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants