Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make sure the tag being pushed is both annotated and signed #876

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

istankovic
Copy link
Member

Just using '-p' would simply pretty-print the referenced commit for unannotated tags, which would then pass the check since we require signed commits. So make sure the tag really is annotated and signed.

@istankovic istankovic requested a review from a team as a code owner January 22, 2025 12:38
@istankovic istankovic force-pushed the ivan/ensure-signed-tags-attempt-2 branch from 0fbfe2b to aee108d Compare January 22, 2025 12:39
@istankovic istankovic changed the title ci: make sure the tag being pushed is a annotated and signed ci: make sure the tag being pushed is both annotated and signed Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

🐰 Bencher Report

Branchivan/ensure-signed-tags-attempt-2
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.59
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.75
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.37
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
15.32
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14.76
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.98
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
988.16
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.79
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
85.10
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
221.35
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
428.77
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
677.24
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
115.49
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.21
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45.62
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.43
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.16
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
94.46
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18.85
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
114.69
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.34
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.02
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
74.87
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95.23
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
27.17
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.76
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8.92
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.92
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
16.96
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
21.63
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
29.66
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
138.21
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.82
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.95
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
71.37
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50.26
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
137.30
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.87
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.59
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.55
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86.05
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
111.99
🐰 View full continuous benchmarking report in Bencher

@istankovic istankovic force-pushed the ivan/ensure-signed-tags-attempt-2 branch from aee108d to 2313397 Compare January 22, 2025 13:44
Just using '-p' would simply pretty-print the referenced commit for
unannotated tags, which would then pass the check since we require
signed commits. So make sure the tag really is annotated and signed.
@istankovic istankovic force-pushed the ivan/ensure-signed-tags-attempt-2 branch from 2313397 to d4e0e75 Compare January 22, 2025 14:40
@istankovic istankovic merged commit d4e0e75 into main Jan 22, 2025
3 checks passed
@istankovic istankovic deleted the ivan/ensure-signed-tags-attempt-2 branch January 22, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants