-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.x] chore: emit info log when buffering, restoring, or clearing future messages #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit e6d3e90)
SimonThormeyer
changed the title
Simon/chore/improve logging 3.x
chore: emit info log when buffering, restoring, or clearing future messages
Jan 27, 2025
SimonThormeyer
changed the title
chore: emit info log when buffering, restoring, or clearing future messages
[3.x] chore: emit info log when buffering, restoring, or clearing future messages
Jan 27, 2025
SimonThormeyer
force-pushed
the
simon/chore/improve-logging-3.x
branch
from
January 27, 2025 10:57
c74c432
to
0fd6213
Compare
coriolinus
approved these changes
Jan 27, 2025
…leanly again With most new rustc versions come new lints. These are great, because they cause our codebase to gradually improve. But they necessitate commits like this from time to time where a lint got stricter. (cherry picked from commit a7ac605)
(cherry picked from commit 7049e08)
…essage error This is to enable logging the epoch after buffering a message.
…le_future_message()` This was meaningless because in the one and only caller this error would always be propagated. So we can just keep it in that context and raise it from there directly. No need for an extra round trip. (cherry picked and adjusted from commit 5d7af36)
…ssages (cherry picked and adapted from commit 08b4563)
SimonThormeyer
force-pushed
the
simon/chore/improve-logging-3.x
branch
2 times, most recently
from
January 27, 2025 11:53
d96a6ca
to
6934837
Compare
The recent 1.2 release apparently had some breaking changes for us.
SimonThormeyer
force-pushed
the
simon/chore/improve-logging-3.x
branch
from
January 27, 2025 12:05
6934837
to
740e7e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
See commit messages
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.