Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] chore: emit info log when buffering, restoring, or clearing future messages #886

Merged
merged 8 commits into from
Jan 27, 2025

Conversation

SimonThormeyer
Copy link
Contributor

What's new in this PR

See commit messages


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SimonThormeyer SimonThormeyer marked this pull request as ready for review January 27, 2025 10:51
@SimonThormeyer SimonThormeyer requested a review from a team as a code owner January 27, 2025 10:51
@SimonThormeyer SimonThormeyer changed the title Simon/chore/improve logging 3.x chore: emit info log when buffering, restoring, or clearing future messages Jan 27, 2025
@SimonThormeyer SimonThormeyer changed the title chore: emit info log when buffering, restoring, or clearing future messages [3.x] chore: emit info log when buffering, restoring, or clearing future messages Jan 27, 2025
Copy link

github-actions bot commented Jan 27, 2025

🐰 Bencher Report

Branchsimon/chore/improve-logging-3.x
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
18.55
Commit add f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.82
Commit add f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
9.33
Commit add f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
12.00
Commit add f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
14.69
Commit add f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
16.58
Commit add f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
984.00
Commit add f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.84
Commit add f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
84.03
Commit add f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
218.53
Commit add f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
423.26
Commit add f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
674.77
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
116.47
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
28.29
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
45.99
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
60.96
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
83.93
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
93.90
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
⚠️ NO THRESHOLD
18.58
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
⚠️ NO THRESHOLD
115.78
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
⚠️ NO THRESHOLD
35.82
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
⚠️ NO THRESHOLD
56.69
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
⚠️ NO THRESHOLD
75.90
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
⚠️ NO THRESHOLD
95.30
Commit remove f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
26.75
Commit remove f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.65
Commit remove f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
8.78
Commit remove f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
12.29
Commit remove f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
17.09
Commit remove f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
21.74
Commit remove f(number clients)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
29.27
Commit remove f(number clients)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
137.32
Commit remove f(number clients)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
115.02
Commit remove f(number clients)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
93.20
Commit remove f(number clients)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
71.59
Commit remove f(number clients)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
50.52
Commit update f(group size)/cs1/mem/1002📈 view plot
⚠️ NO THRESHOLD
137.05
Commit update f(group size)/cs1/mem/2📈 view plot
⚠️ NO THRESHOLD
6.87
Commit update f(group size)/cs1/mem/202📈 view plot
⚠️ NO THRESHOLD
33.49
Commit update f(group size)/cs1/mem/402📈 view plot
⚠️ NO THRESHOLD
59.30
Commit update f(group size)/cs1/mem/602📈 view plot
⚠️ NO THRESHOLD
86.03
Commit update f(group size)/cs1/mem/802📈 view plot
⚠️ NO THRESHOLD
111.85
🐰 View full continuous benchmarking report in Bencher

@SimonThormeyer SimonThormeyer force-pushed the simon/chore/improve-logging-3.x branch from c74c432 to 0fd6213 Compare January 27, 2025 10:57
coriolinus and others added 5 commits January 27, 2025 12:20
…leanly again

With most new rustc versions come new lints. These are great, because
they cause our codebase to gradually improve. But they necessitate
commits like this from time to time where a lint got stricter.

(cherry picked from commit a7ac605)
…essage error

This is to enable logging the epoch after buffering a message.
…le_future_message()`

This was meaningless because in the one and only caller this error would always be propagated.
So we can just keep it in that context and raise it from there directly.
No need for an extra round trip.

(cherry picked and adjusted from commit 5d7af36)
@SimonThormeyer SimonThormeyer force-pushed the simon/chore/improve-logging-3.x branch 2 times, most recently from d96a6ca to 6934837 Compare January 27, 2025 11:53
The recent 1.2 release apparently had some breaking changes for us.
@SimonThormeyer SimonThormeyer force-pushed the simon/chore/improve-logging-3.x branch from 6934837 to 740e7e4 Compare January 27, 2025 12:05
@SimonThormeyer SimonThormeyer merged commit 740e7e4 into release/3.x Jan 27, 2025
30 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/chore/improve-logging-3.x branch January 27, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants