Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: publishing for android #900

Merged
merged 4 commits into from
Feb 1, 2025
Merged

fix: publishing for android #900

merged 4 commits into from
Feb 1, 2025

Conversation

typfel
Copy link
Member

@typfel typfel commented Jan 31, 2025

What's new in this PR

Publishing for android was failing due to a bug in Dokka javadoc generation so we are disabling it for now.


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

We were renaming `Exception` to `Error` in the generated Kotlin code but this was
operating on the wrong file so it had not affect. Also we no longer expose this
type to the consumer of the bindings so renaming is pointless.
Since we moved the generated uniffi code into separate library (uniffi-android)
the Dokka javadoc generation fails with:

java.lang.UnsupportedOperationException: PermittedSubclasses requires ASM9

Since we haven't found a solution for this bug we are disabling javadoc generation
for the time being.
@typfel typfel requested a review from a team as a code owner January 31, 2025 22:56
Copy link

github-actions bot commented Jan 31, 2025

🐰 Bencher Report

Branchfix/publishing-android
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
18.92
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.76
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
9.37
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.81
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
14.80
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
16.81
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
986.54
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
6.74
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
84.40
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
222.22
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
424.70
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
674.99
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
116.77
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
28.36
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
46.79
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
60.72
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
79.36
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
94.37
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
18.89
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
115.20
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
35.96
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
56.88
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
75.73
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
95.36
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
28.14
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.68
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
8.87
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
12.15
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
17.02
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
22.05
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
31.12
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
137.50
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
115.75
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.40
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
72.40
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50.56
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
137.38
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
6.97
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
33.32
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.24
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
86.58
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
111.56
🐰 View full continuous benchmarking report in Bencher

Copy link
Member

@istankovic istankovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@istankovic istankovic merged commit 68af2b3 into main Feb 1, 2025
38 checks passed
@istankovic istankovic deleted the fix/publishing-android branch February 1, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants