-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use entity derive macros for tables with hex ids [WPB-15434] #904
feat: use entity derive macros for tables with hex ids [WPB-15434] #904
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 78.40% 78.21% -0.19%
==========================================
Files 113 111 -2
Lines 20166 19971 -195
==========================================
- Hits 15811 15621 -190
+ Misses 4355 4350 -5
Continue to review full report in Codecov by Sentry.
|
f57660e
to
1192318
Compare
There is no obvious reason to give it another name than the struct. So rename it for parity with the struct name.
There is no obvious reason to give it another name than the struct here, either. So rename it for parity with the struct name.
For parity with the wrapped struct. This makes it compatible with the new derive macro.
1192318
to
8809379
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I only manually looked over the derived implementations for PersistedMlsGroup
, but that one seemed very reasonable.
8809379
to
1afca7d
Compare
What's new in this PR
Subtask of the above item, creating a separate PR to avoid large changeset
PR Submission Checklist for internal contributors
SQPIT-764
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.