Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPB-14931 change coturn defaults, bump charts version #28

Open
wants to merge 2 commits into
base: wireapp/4.6.2-federation
Choose a base branch
from

Conversation

Veki301
Copy link

@Veki301 Veki301 commented Dec 10, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@Veki301 Veki301 changed the title change coturn defaults, bump charts version WPB-14931 change coturn defaults, bump charts version Dec 10, 2024
Copy link

@mastaab mastaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Veki301 why should the defaults be changed? are we sure this does not have any side effects on other environments which are using the defaults?

@Veki301
Copy link
Author

Veki301 commented Dec 11, 2024

it is required for a on-prem HA deployment, current defaults do not work, we should arrange a test on one of the cailleach envs or find a better solution, ill discuss with Julia today
will wait on merging

lwille

This comment was marked as outdated.

Copy link

@lwille lwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I could find in cailleach, we always seem to override these with e.g. __COTURN_HOST_IP__ or __COTURN_EXT_IP__ - which speaks for the default values being dysfunctional

There's another default on the template level:

    listening-ip={{ default "__COTURN_EXT_IP__" .Values.coturnTurnListenIP }}

If we change the default in the Values to be anything but null, we need to remove the defaults in the template to avoid confusion.

To support having different sets of defaults for different environments, we could introduce a second file, e.g. values-local-testing.yaml, and update the docs to reference both files, e.g. helm ... -f values.yaml -f values-local-testing.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants