feat: pass the MLS public key signature algorithm when updating MLS public keys #2720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into feat/WPB-8592
… feat/pass-signature-algorithm-when-registring-mls-client
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
… feat/pass-signature-algorithm-when-registring-mls-client
…registring-mls-client
…le-4.6' into feat/WPB-8592
…registring-mls-client
8 tasks
…gnature-algorithm-when-registring-mls-client # Conflicts: # cryptography/src/androidInstrumentedTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt # cryptography/src/androidUnitTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt # cryptography/src/appleMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentralImpl.kt # cryptography/src/appleTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/CoreCryptoCentral.kt # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt # cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentral.kt # cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt # cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/E2EIClientTest.kt # cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/MLSClientTest.kt # cryptography/src/jsMain/kotlin/com/wire/kalium/cryptography/CoreCryptoCentralImpl.kt # cryptography/src/jsTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt # cryptography/src/jvmTest/kotlin/com/wire/kalium/cryptography/BaseMLSClientTest.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/MLSClientProvider.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/ProteusClientProvider.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/mls/CipherSuite.kt
mchenani
approved these changes
May 2, 2024
vitorhugods
changed the title
alexandreferris
approved these changes
May 2, 2024
MohamadJaara
deleted the
feat/pass-signature-algorithm-when-registring-mls-client
branch
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
pass the MLS public key signature algorithm when updating MLS public keys
Solutions
whe getting the public key form MLS client also append the cipher suite used for that key and then mapped it to a signature algorithm that is used when uploading the key to the backend
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.