Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new MLS cipher suite [WPB-8592] 🍒 🍒 #2752

Merged
merged 5 commits into from
May 26, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 10, 2024

StoryWPB-8592 [Android] Add support for ECDSA ciphersuites

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  1. a new MLS cipher suite need to be supported
  2. the info about the cipher suite if customizable by the backend

Solutions

parse and store the default cipher suite info from the server and use it to start the MLS client

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

* Commit with unresolved merge conflicts

* fix merge issues

---------

Co-authored-by: Mohamad Jaara <[email protected]>
Copy link
Contributor Author

github-actions bot commented May 13, 2024

Test Results

3 041 tests  +1   2 937 ✔️ +1   3m 5s ⏱️ -26s
   528 suites ±0      104 💤 ±0 
   528 files   ±0          0 ±0 

Results for commit 3194221. ± Comparison against base commit bbd2621.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented May 13, 2024

Datadog Report

Branch report: feat/WPB-8592-cherry-pick-cherry-pick
Commit report: d92d03b
Test service: kalium-jvm

✅ 0 Failed, 2937 Passed, 104 Skipped, 9.79s Total Time

@vitorhugods vitorhugods added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue May 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2024
@MohamadJaara MohamadJaara enabled auto-merge May 25, 2024 12:08
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MohamadJaara MohamadJaara added this pull request to the merge queue May 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2024
@MohamadJaara MohamadJaara added this pull request to the merge queue May 26, 2024
Merged via the queue into develop with commit 81cf9dc May 26, 2024
21 checks passed
@MohamadJaara MohamadJaara deleted the feat/WPB-8592-cherry-pick-cherry-pick branch May 26, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants