feat: set the correct cipher suite when claiming key packages [WPB-8592] 🍒 🍒 #2780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: feature ✨
👕 size: XL
🚨 Potential breaking changes
labels
…set-the-correct-cipher-suite-when-claiming-key-packeges-cherry-pick-cherry-pick # Conflicts: # cryptography/src/commonTest/kotlin/com/wire/kalium/cryptography/MLSClientTest.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationGroupRepository.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/client/E2EIClientProviderTest.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/feature/mlsmigration/MLSMigratorTest.kt
Signed-off-by: MohamadJaara <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 2956 Passed, 105 Skipped, 14.36s Total Time |
MohamadJaara
approved these changes
Jun 5, 2024
Test Results3 061 tests +1 2 956 ✔️ +1 4m 0s ⏱️ +38s Results for commit 5f75f4f. ± Comparison against base commit 0d0fb27. This pull request removes 2 and adds 3 tests. Note that renamed tests count towards both.This pull request removes 1 skipped test and adds 1 skipped test. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
mchenani
approved these changes
Jun 5, 2024
…set-the-correct-cipher-suite-when-claiming-key-packeges-cherry-pick-cherry-pick
MohamadJaara
force-pushed
the
feat/set-the-correct-cipher-suite-when-claiming-key-packeges-cherry-pick-cherry-pick
branch
from
211685d to
5f75f4f
Compare
|
MohamadJaara
deleted the
feat/set-the-correct-cipher-suite-when-claiming-key-packeges-cherry-pick-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Claims key packages does not set the correct cipher suite to the backend
Solutions
set the correct cipher suite when claiming key packages
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.