Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Group call not working when MLS is enabled (WPB-9114) 🍒 🍒 #2781

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 22, 2024

BugWPB-9114 [Android] Group calling not working when MLS is enabled

This PR was automatically cherry-picked based on the following PR:

Original PR description:


This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Group calling not working when MLS is enabled

Causes (Optional)

Caused by: px.c: Field 'cipher_suite' is required for type with serial name 'com.wire.kalium.network.api.base.authenticated.conversation.SubconversationResponse', but it was missing at path: $

cipher_suite argument in ConversationResponse should be optional

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@vitorhugods vitorhugods enabled auto-merge June 5, 2024 19:23
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor Author

github-actions bot commented Jun 5, 2024

Test Results

3 061 tests  ±0   2 956 ✔️ ±0   3m 46s ⏱️ +42s
   530 suites ±0      105 💤 ±0 
   530 files   ±0          0 ±0 

Results for commit 48b16b0. ± Comparison against base commit c84da7b.

♻️ This comment has been updated with latest results.

@vitorhugods vitorhugods added this pull request to the merge queue Jun 5, 2024
@datadog-wireapp
Copy link

Datadog Report

Branch report: Group-calling-not-working-when-MLS-is-enabled-cherry-pick-cherry-pick
Commit report: df1e727
Test service: kalium-jvm

✅ 0 Failed, 2956 Passed, 105 Skipped, 11.85s Total Time

Merged via the queue into develop with commit 33e056c Jun 5, 2024
21 checks passed
@vitorhugods vitorhugods deleted the Group-calling-not-working-when-MLS-is-enabled-cherry-pick-cherry-pick branch June 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants