-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: delete unused WireCryptobox binaries #2792
chore: delete unused WireCryptobox binaries #2792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should also remove Cartfile
and Cartfile.resolved
they are also related to Carthage.
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 2919 Passed, 52 Skipped, 11.38s Total Time ❌ Failed Tests (1)
|
…ox-apple-binaries
Quality Gate passedIssues Measures |
* chore: delete unused WireCryptobox bindings * address PR comments
* chore: delete unused WireCryptobox bindings * address PR comments Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
delete unused WireCryptobox bindings
Needs releases with:
Testing
iOS test should pass
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.