feat: CRL proxy [WPB-8793] #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
mchenani,
MohamadJaara and
ohassine
and removed request for
mchenani
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
Signed-off-by: Boris Safonov <[email protected]>
|
ohassine
approved these changes
Jun 6, 2024
mchenani
reviewed
Jun 6, 2024
logic/src/commonMain/kotlin/com/wire/kalium/logic/configuration/E2EISettings.kt
Show resolved
Hide resolved
mchenani
reviewed
Jun 6, 2024
network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEApi.kt
Show resolved
Hide resolved
mchenani
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
Issues
The web/desktop frontend use a proxy to fetch CRLs from other domains. However Android clients fetch those CRLs directly.
Causes (Optional)
It was implemented like this.
Solutions
Implement usage of proxy url for fetching CRLs when it's required and available.