fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: use case to send button action confirmations (WPB-2633) * Fixed issue with domain of button sender
* feat: testservice can send poll message buttons (WPB-2633) (#2377) * feat: testservice can send poll message buttons (WPB-2633) * Remove not needed nullable & check for parameter * Add test for button change * Use specific use case for composite message * Revert change in SendTextMessageUseCase --------- Co-authored-by: Mojtaba Chenani <[email protected]> * fix: Solved merge conflict that removed PR 2393 and 2377 * feat: use case to send button action confirmations (WPB-2633) * Fixed issue with domain of button sender --------- Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
mchenani
requested review from
MohamadJaara and
typfel
and removed request for
MohamadJaara
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
…when-kalium-start-migration
|
| @@ -619,6 +620,7 @@ internal class MLSConversationDataSource( | |||
| externalSenders: ByteArray, | |||
| allowPartialMemberList: Boolean = false, | |||
| ): Either<CoreFailure, MLSAdditionResult> = withContext(serialDispatcher) { | |||
| kaliumLogger.d("establish MLS group: $groupID") | |||
There was a problem hiding this comment.
is it fine to log the full group id here ?
There was a problem hiding this comment.
yes. there is no harm in it. hmm, but I can remove it if we want.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## testservice-release-cycle-4.6 #2812 +/- ##
================================================================
Coverage ? 58.39%
Complexity ? 7
================================================================
Files ? 1187
Lines ? 46713
Branches ? 4431
================================================================
Hits ? 27278
Misses ? 17452
Partials ? 1983
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
mchenani
changed the base branch from
testservice-release-cycle-4.6
to
release/android-cycle-4.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
When Android/Kalium starts the migration flow, we actually creating the MLS Conversation, and due to the agreement that the BE will not set the Correct CS in the Create Conversation Response, we need to ignore that value; in the normal conversation creation this was considered, but not in the migration flow.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.