-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) #2815
fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) #2815
Conversation
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/mlsmigration/MLSMigrator.kt
Show resolved
Hide resolved
…-kalium-start-migration-4.6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/android-cycle-4.6 #2815 +/- ##
============================================================
Coverage ? 58.39%
Complexity ? 7
============================================================
Files ? 1185
Lines ? 46613
Branches ? 4429
============================================================
Hits ? 27220
Misses ? 17413
Partials ? 1980
Continue to review full report in Codecov by Sentry.
|
…-kalium-start-migration-4.6
Quality Gate passedIssues Measures |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
When Android/Kalium starts the migration flow, we actually creating the MLS Conversation, and due to the agreement that the BE will not set the Correct CS in the Create Conversation Response, we need to ignore that value; in the normal conversation creation this was considered, but not in the migration flow.
Testing
Test Coverage (Optional)
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.