Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls-migration): set correct CS when Kalium start migration (WPB-9638) #2815

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

When Android/Kalium starts the migration flow, we actually creating the MLS Conversation, and due to the agreement that the BE will not set the Correct CS in the Create Conversation Response, we need to ignore that value; in the normal conversation creation this was considered, but not in the migration flow.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • Have a team without MLS enabled
  • Login on android and web
  • Create a Proteus group and send some messages
  • Enable MLS and set the migration to be started
  • Log out and log in on Android, the android app must start the migration to MLS
  • Web ( without reloading the web-app) and android app must be able to send and receive messages and the group must be established as MLS

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Jun 18, 2024

Test Results

2 874 tests   2 856 ✔️  4m 48s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit b25aaa6.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jun 18, 2024

Datadog Report

All test runs 2394bb4 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2761 123 1.42s Link
kalium-jvm 0 0 0 2902 107 6.18s Link

@mchenani mchenani enabled auto-merge (squash) June 21, 2024 08:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release/android-cycle-4.6@1fdaa4f). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             release/android-cycle-4.6    #2815   +/-   ##
============================================================
  Coverage                             ?   58.39%           
  Complexity                           ?        7           
============================================================
  Files                                ?     1185           
  Lines                                ?    46613           
  Branches                             ?     4429           
============================================================
  Hits                                 ?    27220           
  Misses                               ?    17413           
  Partials                             ?     1980           
Files Coverage Δ
...gic/data/conversation/MLSConversationRepository.kt 82.37% <100.00%> (ø)
...e/kalium/logic/feature/mlsmigration/MLSMigrator.kt 78.37% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fdaa4f...de3ee00. Read the comment docs.

Copy link

@mchenani mchenani merged commit b303b85 into release/android-cycle-4.6 Jun 24, 2024
18 checks passed
@mchenani mchenani deleted the fix/set-correct-cs-when-kalium-start-migration-4.6 branch June 24, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants