fix: Stuck on Setting up Wire after canceling E2EI during login [WPB-10046] 🍒 🍒 #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
MohamadJaara,
vitorhugods,
mchenani and
saleniuk
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
saleniuk
approved these changes
Jul 23, 2024
Datadog ReportBranch report: ✅ 0 Failed, 3018 Passed, 105 Skipped, 12.85s Total Time |
MohamadJaara
approved these changes
Jul 23, 2024
…ter_canceling_e2ei_during_login-fixed-cherry-pick-cherry-pick
|
MohamadJaara
deleted the
fix/stuck_on_setting_up_wire_after_canceling_e2ei_during_login-fixed-cherry-pick-cherry-pick
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Mohamad Jaara <[email protected]>
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was manually cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
When the user wants to login with his second account, and cancels generating his certificate and then tries to login again, he’s stuck on setting up wire screen.
Causes (Optional)
When user trying to login to the same acc as already tried, client is already exist. Checking "if E2EI is required" was missed for existed clients.
Solutions
Add checking if E2EI is required for the case when user login into existed client (
VerifyExistingClientUseCase).And update unit tests.