feat: terminate the SFT OneOnOneCall once the other person hangup the call (WPB-7153) #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when-needed-cherry-pick-4-6
…ed-cherry-pick-4-6' into useSFTForOneToOneCalls-when-needed-cherry-pick-4-6
…delete-Remote-Sub-Conversation-OneOnOneCall-On-SFT # Conflicts: # logic/src/commonJvmAndroid/kotlin/com/wire/kalium/logic/feature/call/CallManagerImpl.kt # logic/src/commonJvmAndroid/kotlin/com/wire/kalium/logic/feature/call/GlobalCallManager.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/featureConfig/FeatureConfigMapper.kt
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
ohassine
changed the title
echoes-hq
bot
added
the
echoes: product-roadmap
ohassine
requested review from
a team,
typfel,
alexandreferris,
MohamadJaara,
mchenani and
Garzas
and removed request for
a team
alexandreferris
approved these changes
Aug 1, 2024
|
MohamadJaara
approved these changes
Aug 5, 2024
MohamadJaara
deleted the
delete-Remote-Sub-Conversation-OneOnOneCall-On-SFT
branch
This was referenced Aug 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Description
A follow up PR of #2907
When two participants are in a 1:1 MLS call on SFT, if someone ends the call, the call will stay ongoing for the other person until timout.
This is because we don't rely on the SFT list, but we have a subconversation that we use for calling.
To resolve that, we agreed on a short term approch which aims to :
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.