Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ignoreDisabledTargets when building with CI that does not support apple targets 🍒 #2945

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

removing unwanted gradle logs about not supported targets

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

… apple targets (#2944)

* ciL: ignoreDisabledTargets when building with CI that does not support apple targets

* Trigger CI

Signed-off-by: MohamadJaara <[email protected]>

---------

Signed-off-by: MohamadJaara <[email protected]>
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch 👕 size: XS labels Aug 12, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

@MohamadJaara MohamadJaara merged commit 27532f3 into develop Sep 2, 2024
16 of 17 checks passed
@MohamadJaara MohamadJaara deleted the ci/fix-fdroid-build-cherry-pick branch September 2, 2024 08:11
Copy link
Contributor Author

github-actions bot commented Sep 2, 2024

🐰Bencher

ReportMon, September 2, 2024 at 08:21:39 UTC
Projectkalium
Branchci/fix-fdroid-build-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)688,881.89
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)342,119,519.00
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)922,362,046.48
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,239,110.87

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.60%. Comparing base (dd8b1dc) to head (3624409).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2945      +/-   ##
===========================================
- Coverage    52.60%   52.60%   -0.01%     
===========================================
  Files         1296     1296              
  Lines        49823    49823              
  Branches      4648     4648              
===========================================
- Hits         26208    26207       -1     
  Misses       21739    21739              
- Partials      1876     1877       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8b1dc...3624409. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants