fix: Check file extension instead of mimeType [WPB-10605] 🍒 #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
type: bug / fix 🐞
👕 size: L
🚨 Potential breaking changes
labels
MohamadJaara
approved these changes
Aug 16, 2024
…d-of-mimetype-cherry-pick
borichellow
approved these changes
Aug 16, 2024
|
Datadog ReportBranch report: ✅ 0 Failed, 3074 Passed, 105 Skipped, 9.82s Total Time |
borichellow
deleted the
fix/check-file-extension-instead-of-mimetype-cherry-pick
branch
github-actions bot
added a commit
that referenced
this pull request
Aug 16, 2024
* Commit with unresolved merge conflicts * Fixed cherry-pick issues --------- Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
…2956) * Commit with unresolved merge conflicts * Fixed cherry-pick issues --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: boris <[email protected]> Co-authored-by: Boris Safonov <[email protected]> Co-authored-by: Mohamad Jaara <[email protected]>
echoes-hq
bot
added
the
echoes: unplanned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
What's new in this PR?
Issues
in
ValidateAssetMimeTypeUseCasewhen we calculate if file can be shared or not we were comparing files mimeType to list of allowed Extensions.Causes (Optional)
Just was implemented in that way long time ago.
Solutions
fix it and compare files extension to list of allowed Extensions.