Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): pick one-on-one proteus conversation in alphabetically order for MLS migration (WPB-10259) #2962

Conversation

mchenani
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Based on Product agreement, if the user has multiple Proteus conversation, during the migration we must pick the first one in alphabetically order.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 21, 2024

Test Results

2 918 tests   2 900 ✔️  12m 43s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit e76dd4b.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Aug 21, 2024

Datadog Report

All test runs d321269 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
kalium-ios 0 0 0 2805 123 1.62s Link
kalium-jvm 0 0 0 2956 107 5.62s Link

@mchenani mchenani enabled auto-merge (squash) August 22, 2024 14:01
Copy link

@mchenani mchenani merged commit 5cad6c8 into release/android-cycle-4.6 Aug 22, 2024
19 checks passed
@mchenani mchenani deleted the fix/pick-oneonone-migration-target-alphabetically branch August 22, 2024 15:02
github-actions bot pushed a commit that referenced this pull request Aug 22, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 9, 2024
…phabetically order (#2962) (#2964)

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Boris Safonov <[email protected]>
github-actions bot added a commit that referenced this pull request Sep 9, 2024
…phabetically order (#2962) (#2964)

Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Boris Safonov <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 13, 2024
…phabetically order (#2962) (#2964) (#2996)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mojtaba Chenani <[email protected]>
Co-authored-by: Boris Safonov <[email protected]>
Co-authored-by: Mohamad Jaara <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: unplanned Any work item that isn’t part of the product or technical roadmap. 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants