Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade gradle wrapper to match gradle version [WPB-10569] 🍒 #2973

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 28, 2024

TaskWPB-10569 [Android] publish fdroid

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

missing distributionSha256Sum
gradle vs wrapper version mismatch

Solutions

run

./gradlew wrapper --gradle-version 8.8 \
  --gradle-distribution-sha256-sum f8b4f4772d302c8ff580bc40d0f56e715de69b163546944f787c87abf209c961

to fix it

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

)

* chore: upgrade gradle wrapper to match gradle version

* force -all

* revert unwanted changes
@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. type: chore 🧹 👕 size: L labels Aug 28, 2024
@yamilmedina yamilmedina enabled auto-merge August 29, 2024 07:20
Copy link

Copy link
Contributor Author

github-actions bot commented Aug 29, 2024

Test Results

3 175 tests  ±0   3 070 ✔️ ±0   3m 36s ⏱️ -25s
   545 suites ±0      105 💤 ±0 
   545 files   ±0          0 ±0 

Results for commit b349ab2. ± Comparison against base commit 9f4a150.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

🐰Bencher

ReportThu, August 29, 2024 at 07:36:18 UTC
Projectkalium
Branchchore/update-gradle-wrapper-cherry-pick
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles➖ (view plot)684,347.36
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory➖ (view plot)703,408,410.01
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark➖ (view plot)930,762,262.15
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark➖ (view plot)21,087,232.74

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@yamilmedina yamilmedina added this pull request to the merge queue Aug 29, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.52%. Comparing base (9f4a150) to head (b349ab2).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2973      +/-   ##
===========================================
- Coverage    52.53%   52.52%   -0.01%     
===========================================
  Files         1294     1294              
  Lines        49639    49639              
  Branches      4618     4618              
===========================================
- Hits         26078    26074       -4     
- Misses       21693    21697       +4     
  Partials      1868     1868              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f4a150...b349ab2. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/update-gradle-wrapper-cherry-pick
Commit report: b2aade0
Test service: kalium-jvm

✅ 0 Failed, 3070 Passed, 105 Skipped, 12.12s Total Time

Merged via the queue into develop with commit 93f9696 Aug 29, 2024
22 checks passed
@yamilmedina yamilmedina deleted the chore/update-gradle-wrapper-cherry-pick branch August 29, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch echoes: technical-roadmap/security More specific category, to highlight task that tackle security requirements. echoes: technical-roadmap/technical-debt More specific category, to highlight Technical Debt being tackled. 👕 size: L type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants