fix(mls): fetch and set mls-removal keys for 1on1 conversations (WPB-10743) 🍒 #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
echoes: unplanned
vitorhugods
reviewed
Sep 25, 2024
...kotlin/com/wire/kalium/logic/feature/conversation/JoinExistingMLSConversationsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
...kotlin/com/wire/kalium/logic/feature/conversation/JoinExistingMLSConversationsUseCaseTest.kt
Outdated
Show resolved
Hide resolved
network/src/commonMain/kotlin/com/wire/kalium/network/api/v6/authenticated/ConversationApiV6.kt
Outdated
Show resolved
Hide resolved
network/src/commonMain/kotlin/com/wire/kalium/network/api/v6/authenticated/ConversationApiV6.kt
Outdated
Show resolved
Hide resolved
...onMain/kotlin/com/wire/kalium/network/api/authenticated/conversation/ConversationResponse.kt
Outdated
Show resolved
Hide resolved
...onMain/kotlin/com/wire/kalium/network/api/authenticated/conversation/ConversationResponse.kt
Outdated
Show resolved
Hide resolved
…into fix/mls-1on1-removal-keys-cherry-pick # Conflicts: # network-model/src/commonMain/kotlin/com/wire/kalium/network/api/authenticated/conversation/ConversationResponse.kt # network/src/commonMain/kotlin/com/wire/kalium/network/api/v6/authenticated/ConversationApiV6.kt
|
MohamadJaara
approved these changes
Sep 26, 2024
Datadog ReportBranch report: ✅ 0 Failed, 3098 Passed, 107 Skipped, 11.64s Total Time |
vitorhugods
approved these changes
Sep 27, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Fetch and set removal-keys from the get-oneonone-conversation response for 1on1 conversations and only APIV6
Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.