Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: convert ForegroundNotificationDetailsProvider to fun interface #3070

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

kl3jvi
Copy link
Contributor

@kl3jvi kl3jvi commented Oct 22, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.01%. Comparing base (94d387e) to head (b7a972a).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3070      +/-   ##
===========================================
- Coverage    54.02%   54.01%   -0.01%     
===========================================
  Files         1232     1232              
  Lines        35979    35979              
  Branches      3646     3646              
===========================================
- Hits         19436    19433       -3     
- Misses       15141    15143       +2     
- Partials      1402     1403       +1     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d387e...b7a972a. Read the comment docs.

---- 🚨 Try these New Features:

@kl3jvi
Copy link
Contributor Author

kl3jvi commented Nov 18, 2024

@vitorhugods Anything else I can do for this PR?

@vitorhugods
Copy link
Member

@vitorhugods Anything else I can do for this PR?

No no, it's alright.
Because of our broken checks for PRs coming from forks this also makes it trickier on our side. We'd usually just add to the merge queue and have it merged easily.

I'll trigger the tests now, and if they succeed I'll just merge manually.

@vitorhugods vitorhugods added this pull request to the merge queue Nov 19, 2024
Merged via the queue into wireapp:develop with commit 78c1bbf Nov 19, 2024
15 of 21 checks passed
@kl3jvi kl3jvi deleted the patch-1 branch November 25, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants