feat: Create use case for calling activated status #WPB-1826

[m-zagorski]

WPB-1826 Implement correct alert for non paying team members

https://wearezeta.atlassian.net/browse/WPB-1826

What's new in this PR?

Issues

We needed a way to know when we've updated from being unable to start conference call to when we're able, so when we have upgraded to enterprise.

Solutions

We observe current value and zip it with the upcoming one to know if we have moved from false->true

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

3 295 tests  +40   3 188 ✅ +39   4m 53s ⏱️ +44s
  562 suites + 6     107 💤 + 1 
  562 files   + 6       0 ❌ ± 0 

Results for commit e52f4c3. ± Comparison against base commit 1f3c946.

This pull request removes 4 and adds 44 tests. Note that renamed tests count towards both.

com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAConversationHasLastMessageAndDraft_whenObservingConversationListDetails_ThenCorrectlyGetLastMessage[jvm]
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAOneToOneConversationHasNewMessages_whenObservingConversationListDetails_ThenCorrectlyGetUnreadMessageCount[jvm]
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAOneToOneConversationHasNotNewMessages_whenGettingConversationDetails_ThenReturnZeroUnreadMessageCount[jvm]
com.wire.kalium.persistence.dao.message.draft.MessageDraftDAOTest ‑ givenAlreadyExistingMessageDraft_whenUpserting_thenItShouldBeProperlyUpdatedInDb[jvm]

QualifiedIdTest ‑ givenIdsWithDifferentDomains_whenEqualsIgnoringBlankDomain_thenReturnsFalse[jvm]
QualifiedIdTest ‑ givenIdsWithDifferentValues_whenEqualsIgnoringBlankDomain_thenReturnsFalse[jvm]
QualifiedIdTest ‑ givenIdsWithSameDomains_whenEqualsIgnoringBlankDomain_thenReturnsTrue[jvm]
QualifiedIdTest ‑ givenIdsWithoutDomains_whenEqualsIgnoringBlankDomain_thenReturnsTrue[jvm]
QualifiedIdTest ‑ givenOneIdWithoutDomain_whenEqualsIgnoringBlankDomain_thenReturnsTrue[jvm]
com.wire.kalium.api.authenticated.client.ClientDTOSerializationTest ‑ givenJsonWithCapabilitiesList_whenDeserialize_thenReturnCapabilities[jvm]
com.wire.kalium.api.authenticated.client.ClientDTOSerializationTest ‑ givenJsonWithCapabilitiesObjectWrapperList_whenDeserialize_thenReturnCapabilities[jvm]
com.wire.kalium.api.v7.ConversationApiV7Test ‑ given200Response_whenCallingFetchMlsOneToOneConversation_thenResponseIsParsedCorrectly[jvm]
com.wire.kalium.api.v7.ConversationApiV7Test ‑ whenCallingFetchMlsOneToOneConversation_thenTheRequestShouldBeConfiguredOK[jvm]
com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAGroupConversationHasNewMessages_whenObservingConversationListDetails_ThenCorrectlyGetUnreadMessageCount[jvm]
…

This pull request skips 1 test.

com.wire.kalium.logic.data.conversation.ConversationRepositoryTest ‑ givenAGroupConversationHasNotNewMessages_whenGettingConversationDetails_ThenReturnZeroUnreadMessageCount[jvm]

♻️ This comment has been updated with latest results.

[github-actions]

Bencher Report

Branch	feat/has-conference-calling-activated-use-case
Testbed	ubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

• Latency (nanoseconds (ns))

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	📈 view plot ⚠️ NO THRESHOLD	655,688.67
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	📈 view plot ⚠️ NO THRESHOLD	351,257,635.52
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	📈 view plot ⚠️ NO THRESHOLD	1,318,027,953.22
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	📈 view plot ⚠️ NO THRESHOLD	21,804,268.73

🐰 View full continuous benchmarking report in Bencher

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes missing coverage. Please review.

Project coverage is 54.07%. Comparing base (1f3c946) to head (e52f4c3).
Report is 23 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ire/kalium/persistence/config/UserConfigStorage.kt	57.14%	3 Missing ⚠️
...kalium/logic/configuration/UserConfigRepository.kt	0.00%	1 Missing ⚠️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt	0.00%	1 Missing ⚠️
.../usecase/ObserveConferenceCallingEnabledUseCase.kt	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3087      +/-   ##
===========================================
+ Coverage    52.69%   54.07%   +1.37%     
===========================================
  Files         1320     1234      -86     
  Lines        51166    36047   -15119     
  Branches      4746     3656    -1090     
===========================================
- Hits         26963    19491    -7472     
+ Misses       22276    15145    -7131     
+ Partials      1927     1411     -516     

Files with missing lines	Coverage Δ
...kalium/logic/configuration/UserConfigRepository.kt	36.58% <0.00%> (-0.18%)	⬇️
...n/com/wire/kalium/logic/feature/call/CallsScope.kt	0.00% <0.00%> (ø)
.../usecase/ObserveConferenceCallingEnabledUseCase.kt	87.50% <87.50%> (ø)
...ire/kalium/persistence/config/UserConfigStorage.kt	71.75% <57.14%> (-0.41%)	⬇️

... and 229 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f3c946...e52f4c3. Read the comment docs.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[datadog-wireapp]

Datadog Report

Branch report: feat/has-conference-calling-activated-use-case
Commit report: d6170e7
Test service: kalium-jvm

✅ 0 Failed, 3188 Passed, 107 Skipped, 35.1s Total Time

[m-zagorski]

@vitorhugods would you mind taking another look ? :)

[borichellow]

just a few small suggestion that are not blocking the PR :)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud