Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folders now found [WPB-11639] #3111

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: folders now found [WPB-11639] #3111

merged 1 commit into from
Nov 19, 2024

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 19, 2024

StoryWPB-11639 [Android] User Story for Add to favourites/Remove from favourites


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Slow sync fails when there are no folders on user properties

Causes (Optional)

User is stucked on login

Solutions

Handle not found error and create favorite folder

@Garzas Garzas self-assigned this Nov 19, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 19, 2024
@Garzas Garzas enabled auto-merge November 19, 2024 10:53
Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨 🎸

Copy link
Contributor

github-actions bot commented Nov 19, 2024

Test Results

3 289 tests  +1   3 182 ✅ +1   5m 4s ⏱️ +3s
  561 suites ±0     107 💤 ±0 
  561 files   ±0       0 ❌ ±0 

Results for commit 7d61df2. ± Comparison against base commit 94d387e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🐰 Bencher Report

Branchfix/folders-not-found
Testbedubuntu-latest

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles📈 view plot
⚠️ NO THRESHOLD
662,941.00
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory📈 view plot
⚠️ NO THRESHOLD
322,984,434.22
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark📈 view plot
⚠️ NO THRESHOLD
1,325,786,169.43
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark📈 view plot
⚠️ NO THRESHOLD
21,637,616.94
🐰 View full continuous benchmarking report in Bencher

@Garzas Garzas added this pull request to the merge queue Nov 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.05%. Comparing base (94d387e) to head (7d61df2).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../conversation/folders/ConversationFolderMappers.kt 81.81% 1 Missing and 1 partial ⚠️
...nversation/folders/ConversationFolderRepository.kt 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3111      +/-   ##
===========================================
+ Coverage    54.02%   54.05%   +0.03%     
===========================================
  Files         1232     1232              
  Lines        35979    36000      +21     
  Branches      3646     3650       +4     
===========================================
+ Hits         19436    19460      +24     
+ Misses       15141    15133       -8     
- Partials      1402     1407       +5     
Files with missing lines Coverage Δ
.../conversation/folders/ConversationFolderMappers.kt 60.00% <81.81%> (+8.27%) ⬆️
...nversation/folders/ConversationFolderRepository.kt 91.30% <80.00%> (+24.63%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d387e...7d61df2. Read the comment docs.

---- 🚨 Try these New Features:

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/folders-not-found
Commit report: 4d5524c
Test service: kalium-jvm

✅ 0 Failed, 3182 Passed, 107 Skipped, 35.8s Total Time

Merged via the queue into develop with commit e617c90 Nov 19, 2024
23 checks passed
@Garzas Garzas deleted the fix/folders-not-found branch November 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. 🚨 Potential breaking changes 👕 size: S type: bug / fix 🐞
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants