-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support other message types [WPB-10575] #3122
feat: support other message types [WPB-10575] #3122
Conversation
c454a1e
to
8b78c9b
Compare
Test Results3 313 tests 3 206 ✅ 5m 19s ⏱️ Results for commit 6157bf2. ♻️ This comment has been updated with latest results. |
|
Branch | feat/support-other-message-types |
Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholds
CLI flag.
Click to view all benchmark results
Benchmark | Latency | nanoseconds (ns) |
---|---|---|
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot | 657,889.80 |
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot | 552,671,175.09 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot | 1,311,862,234.60 |
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot | 21,536,535.53 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## epic/multiplatform-backup #3122 +/- ##
============================================================
Coverage ? 54.03%
============================================================
Files ? 1246
Lines ? 36152
Branches ? 3656
============================================================
Hits ? 19535
Misses ? 15207
Partials ? 1410 Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3206 Passed, 107 Skipped, 38.65s Total Time |
41a7dd2
to
a35c722
Compare
* feat: add metadata for assetd * feat: add metadata for assetd * fix: detekt * feat: metadata logs * feat: generic metadata for images
8a7a13f
to
6157bf2
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Co-authored-by: Yamil Medina <[email protected]>
* chore: create backup module (#3117) This commit introduces a new cross-platform backup module to the project with support for iOS, Web, and Android. Additionally, it enables JavaScript multiplatform support in existing `kalium/network-model` and `kalium/data` projects. * chore: create backup protobuf models (#3116) * feat: add initial crossplatform backup serialization [WPB-10575] (#3121) * feat: support other message types [WPB-10575] (#3122) Co-authored-by: Yamil Medina <[email protected]> * refactor(backup): make visibility modifier mandatory (#3153) * chore(backup): add encrypted stream [WPB-10575] (#3154) * chore(backup): read and write the backup header (#3159) * feat(backup): support export and import of backups on Web, iOS and Android [WPB-10575] (#3228) * refactor(backup): enhance error handling and test coverage (#3248) Refactored the backup import process to improve error handling by introducing more granular failure types and modularized the logic for decrypting and unzipping archives. Added comprehensive test coverage, including tests for edge cases in decryption, parsing, and unzipping. * chore(backup): improve backup export error handling and result encapsulation (#3257) Introduced `BackupExportResult` and `ExportResult` to encapsulate and represent export operation outcomes, including success and specific failure types (`IOError`, `ZipError`). Refactored relevant methods to use these types, added coroutine support annotations, and implemented error handling for zipping and I/O operations. Added unit tests to ensure correct error handling behavior. * feat(backup): support file peeking [WPB-10575] (#3261) Introduced `peekBackup` and related methods to retrieve backup metadata such as version, encryption status, and original creator. Also added unit tests to validate behavior for various cases, including unsupported versions and mismatched user IDs. * feat(backup): paginate different types of content (#3268) Consolidated handling of paginated backup data into the new `BackupPage` concept to improve clarity and support pagination for users, conversations, and messages during import. Added tests to validate the refactored `BackupImportPager`. * docs(backup): add multiplatform sample implementations and documentation (#3269) Introduced examples showcasing `MPBackupImporter` and `MPBackupExporter` usage for different platforms. Updated documentation, README, and build configurations to support multiplatform samples, including JS and non-JS targets. --------- Co-authored-by: Yamil Medina <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
Extend support to other message types, like Assets and Location.
Solutions
Rely for now on the most certain data. We can fine-tune this with other clients later.
Dependencies
Needs releases with:
Testing
Test Coverage
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.