Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move API V6 to supported #WPB-14528 #3135

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Nov 27, 2024

BugWPB-14528 [Android] Not possible to create MLS 1:1 conversations across backends

What's new in this PR?

Issues

Not possible to create MLS 1:1 conversations across backends

Causes (Optional)

creating 1o1 MLS conversation available in API v6 +

Solutions

Move API v6 to supported (it's stable already)

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Test Results

3 330 tests  ±0   3 223 ✅ ±0   5m 16s ⏱️ +34s
  571 suites ±0     107 💤 ±0 
  571 files   ±0       0 ❌ ±0 

Results for commit 7b3a835. ± Comparison against base commit b7b4bd2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.21%. Comparing base (b7b4bd2) to head (7b3a835).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3135      +/-   ##
===========================================
- Coverage    54.21%   54.21%   -0.01%     
===========================================
  Files         1250     1250              
  Lines        36328    36328              
  Branches      3658     3658              
===========================================
- Hits         19697    19694       -3     
- Misses       15218    15220       +2     
- Partials      1413     1414       +1     
Files with missing lines Coverage Δ
...lin/com/wire/kalium/network/BackendMetaDataUtil.kt 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7b4bd2...7b3a835. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/move_api_v6_to_supported
Commit report: 9499088
Test service: kalium-jvm

✅ 0 Failed, 3223 Passed, 107 Skipped, 39.15s Total Time

@MohamadJaara MohamadJaara added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit a02f920 Nov 27, 2024
23 checks passed
@MohamadJaara MohamadJaara deleted the feat/move_api_v6_to_supported branch November 27, 2024 17:18
@echoes-hq echoes-hq bot added the echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/bug Work contributing to resolve a bug not critical enough to have raised an incident. 👕 size: XS type: feature ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants