chore: upgrade to cc3, fixes new_transaction in paralel (WPB-14910) #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamilmedina
requested review from
borichellow,
vitorhugods,
Garzas and
saleniuk
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/candidate #3170 +/- ##
=====================================================
- Coverage 54.14% 54.14% -0.01%
=====================================================
Files 1250 1250
Lines 36457 36457
Branches 3689 3689
=====================================================
- Hits 19739 19738 -1
- Misses 15294 15296 +2
+ Partials 1424 1423 -1 see 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportBranch report: ✅ 0 Failed, 3232 Passed, 107 Skipped, 1m 0.53s Total Time |
m-zagorski
approved these changes
Dec 12, 2024
Garzas
approved these changes
Dec 12, 2024
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2024
Co-authored-by: Yamil Medina <[email protected]>
echoes-hq
bot
added
the
echoes: technical-roadmap
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 9, 2025
* feat: harden ClientCapabilityDTO for api v7 * add tests * detekt * detekt * chore: disable folders update handler (#3161) * fix: Login to second device does not have MLS capabilities RC (#3165) * feat: add usecase to get team url (WPB-14872) (#3157) (#3168) * feat: add usecase to get team url * feat:detekt * feat: detekt * feat: detekt (cherry picked from commit abcd037) * chore: upgrade to cc3, fixes new_transaction in paralell (#3170) * test: add tests for old format parser in capabilities (#3173) * Update libs.versions.toml * Update UserPropertiesEventReceiver.kt * Update UserPropertiesEventReceiver.kt * Update UserPropertiesEventReceiverTest.kt * fix * fix tests * missing imports * fix circular dependency * Trigger CI * remove not needed dependency --------- Co-authored-by: Jakub Żerko <[email protected]> Co-authored-by: Yamil Medina <[email protected]> Co-authored-by: boris <[email protected]> Co-authored-by: Oussama Hassine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Issues when we bumped the version to 2.0 of CoreCrypto.
This version also exposes another ErrorCode, that for now we can ignore as we treat it as Generic.
Solutions
Bump to 3.0 with the fix
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.