-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: messages migration from proteus to mls [WPB-15149] 🍒 #3219
fix: messages migration from proteus to mls [WPB-15149] 🍒 #3219
Conversation
Bencher Report
Click to view all benchmark results
|
Datadog ReportBranch report: ✅ 0 Failed, 3279 Passed, 108 Skipped, 1m 0.81s Total Time |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3219 +/- ##
===========================================
+ Coverage 54.16% 54.48% +0.32%
===========================================
Files 1264 1264
Lines 36852 36858 +6
Branches 3738 3738
===========================================
+ Hits 19960 20083 +123
+ Misses 15453 15365 -88
+ Partials 1439 1410 -29
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When moving messages from proteus conversation to MLS if some message contained reactions or
RestrictedAsset
then migration failed causing slow sync to break.Solutions
Migrate
MessageRestrictedAssetContent
andReaction
tables to update on cascade whenMessage
is changingconversation_id
Testing
Test Coverage (Optional)
How to Test
Attachments (Optional)