Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: skeleton and basic support of v8 api (WPB-15698) #3253

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 27, 2025

TaskWPB-15698 [Android] - Create base network changes for v8 API support


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to kick off the new v8 API from the backend

Solutions

Create the base classes and infrastructure code needed when supporting a new version, using the script generate_new_api_version.sh

No logic, just enabling the v8 dev support.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Member

@vitorhugods vitorhugods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yamilmedina yamilmedina enabled auto-merge January 27, 2025 14:53
Copy link
Contributor

github-actions bot commented Jan 27, 2025

Test Results

3 416 tests  ±0   3 308 ✅ ±0   5m 38s ⏱️ -5s
  584 suites ±0     108 💤 ±0 
  584 files   ±0       0 ❌ ±0 

Results for commit 784d144. ± Comparison against base commit eb886e2.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@yamilmedina yamilmedina added this pull request to the merge queue Jan 27, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0.69930% with 142 lines in your changes missing coverage. Please review.

Project coverage is 53.98%. Comparing base (7456f22) to head (784d144).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...etworkContainer/AuthenticatedNetworkContainerV8.kt 0.00% 48 Missing ⚠️
...workContainer/UnauthenticatedNetworkContainerV8.kt 0.00% 28 Missing ⚠️
.../networkContainer/AuthenticatedNetworkContainer.kt 0.00% 7 Missing ⚠️
...etworkContainer/UnauthenticatedNetworkContainer.kt 0.00% 6 Missing ⚠️
...m/network/api/v8/authenticated/AccessTokenApiV8.kt 0.00% 2 Missing ⚠️
.../kalium/network/api/v8/authenticated/AssetApiV8.kt 0.00% 2 Missing ⚠️
...e/kalium/network/api/v8/authenticated/CallApiV8.kt 0.00% 2 Missing ⚠️
...kalium/network/api/v8/authenticated/ClientApiV8.kt 0.00% 2 Missing ⚠️
...um/network/api/v8/authenticated/ConnectionApiV8.kt 0.00% 2 Missing ⚠️
.../network/api/v8/authenticated/ConversationApiV8.kt 0.00% 2 Missing ⚠️
... and 21 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3253      +/-   ##
===========================================
- Coverage    54.43%   53.98%   -0.46%     
===========================================
  Files         1271     1303      +32     
  Lines        37062    37446     +384     
  Branches      3764     3781      +17     
===========================================
+ Hits         20176    20216      +40     
- Misses       15466    15809     +343     
- Partials      1420     1421       +1     
Files with missing lines Coverage Δ
...lin/com/wire/kalium/network/BackendMetaDataUtil.kt 100.00% <100.00%> (ø)
.../kotlin/com/wire/kalium/logic/GlobalKaliumScope.kt 0.00% <0.00%> (ø)
...m/network/api/v8/authenticated/AccessTokenApiV8.kt 0.00% <0.00%> (ø)
.../kalium/network/api/v8/authenticated/AssetApiV8.kt 0.00% <0.00%> (ø)
...e/kalium/network/api/v8/authenticated/CallApiV8.kt 0.00% <0.00%> (ø)
...kalium/network/api/v8/authenticated/ClientApiV8.kt 0.00% <0.00%> (ø)
...um/network/api/v8/authenticated/ConnectionApiV8.kt 0.00% <0.00%> (ø)
.../network/api/v8/authenticated/ConversationApiV8.kt 0.00% <0.00%> (ø)
...e/kalium/network/api/v8/authenticated/E2EIApiV8.kt 0.00% <0.00%> (ø)
...network/api/v8/authenticated/FeatureConfigApiV8.kt 0.00% <0.00%> (ø)
... and 22 more

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7456f22...784d144. Read the comment docs.

@datadog-wireapp
Copy link

Datadog Report

Branch report: feat/adopt-v8-api
Commit report: 277fa44
Test service: kalium-jvm

✅ 0 Failed, 3308 Passed, 108 Skipped, 1m 0.8s Total Time

Merged via the queue into develop with commit e21b0a8 Jan 27, 2025
23 checks passed
@yamilmedina yamilmedina deleted the feat/adopt-v8-api branch January 27, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants