Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(backup): add documentation and samples [WPB-10575] #3269

Merged

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Jan 31, 2025

StoryWPB-10575 Cross Platform Backup: Write common backup / restore library


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add a bit more documentation about backup, with links to samples and the currently supported data structure.

Note

The links will work once this is merged to develop and Kalium's documentation is rebuilt by CI. But for now, take these screenshots from a local build:

grafik grafik grafik grafik

Dependencies

This PR requires the following PR to be merged:


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. label Jan 31, 2025
@vitorhugods vitorhugods marked this pull request as draft January 31, 2025 17:30
@vitorhugods vitorhugods force-pushed the docs/backup/add-documentation branch from 475f209 to ffb45ab Compare January 31, 2025 17:46
@vitorhugods vitorhugods removed the request for review from sbakhtiarov January 31, 2025 17:47
@vitorhugods vitorhugods changed the title docs(backup): add documentation [WPB-10575] docs(backup): add documentation and samples [WPB-10575] Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Test Results

3 506 tests   3 398 ✅  5m 51s ⏱️
  603 suites    108 💤
  603 files        0 ❌

Results for commit 25258d9.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Jan 31, 2025

Datadog Report

Branch report: docs/backup/add-documentation
Commit report: cb4d062
Test service: kalium-jvm

✅ 0 Failed, 3398 Passed, 108 Skipped, 59.1s Total Time

Introduced examples showcasing `MPBackupImporter` and `MPBackupExporter` usage for different platforms. Updated documentation, README, and build configurations to support multiplatform samples, including JS and non-JS targets.
@vitorhugods vitorhugods force-pushed the docs/backup/add-documentation branch from ffb45ab to 25258d9 Compare February 5, 2025 15:34
@vitorhugods vitorhugods marked this pull request as ready for review February 5, 2025 15:35
Copy link

sonarqubecloud bot commented Feb 5, 2025

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (epic/multiplatform-backup@6f99a66). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             epic/multiplatform-backup    #3269   +/-   ##
============================================================
  Coverage                             ?   53.89%           
============================================================
  Files                                ?     1303           
  Lines                                ?    37404           
  Branches                             ?     3770           
============================================================
  Hits                                 ?    20159           
  Misses                               ?    15835           
  Partials                             ?     1410           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f99a66...25258d9. Read the comment docs.

@vitorhugods vitorhugods merged commit 87e30ee into epic/multiplatform-backup Feb 6, 2025
21 checks passed
@vitorhugods vitorhugods deleted the docs/backup/add-documentation branch February 6, 2025 09:36
github-merge-queue bot pushed a commit that referenced this pull request Feb 7, 2025
* chore: create backup module (#3117)

This commit introduces a new cross-platform backup module to the project with support for iOS, Web, and Android. Additionally, it enables JavaScript multiplatform support in existing `kalium/network-model` and `kalium/data` projects.

* chore: create backup protobuf models (#3116)

* feat: add initial crossplatform backup serialization [WPB-10575] (#3121)

* feat: support other message types [WPB-10575] (#3122)

Co-authored-by: Yamil Medina <[email protected]>

* refactor(backup): make visibility modifier mandatory (#3153)

* chore(backup): add encrypted stream [WPB-10575] (#3154)

* chore(backup): read and write the backup header (#3159)

* feat(backup): support export and import of backups on Web, iOS and Android [WPB-10575] (#3228)

* refactor(backup): enhance error handling and test coverage (#3248)

Refactored the backup import process to improve error handling by introducing more granular failure types and modularized the logic for decrypting and unzipping archives. Added comprehensive test coverage, including tests for edge cases in decryption, parsing, and unzipping.

* chore(backup): improve backup export error handling and result encapsulation (#3257)

Introduced `BackupExportResult` and `ExportResult` to encapsulate and represent export operation outcomes, including success and specific failure types (`IOError`, `ZipError`). Refactored relevant methods to use these types, added coroutine support annotations, and implemented error handling for zipping and I/O operations. Added unit tests to ensure correct error handling behavior.

* feat(backup): support file peeking [WPB-10575] (#3261)

Introduced `peekBackup` and related methods to retrieve backup metadata such as version, encryption status, and original creator. Also added unit tests to validate behavior for various cases, including unsupported versions and mismatched user IDs.

* feat(backup): paginate different types of content (#3268)

Consolidated handling of paginated backup data into the new `BackupPage` concept to improve clarity and support pagination for users, conversations, and messages during import. Added tests to validate the refactored `BackupImportPager`.

* docs(backup): add multiplatform sample implementations and documentation (#3269)

Introduced examples showcasing `MPBackupImporter` and `MPBackupExporter` usage for different platforms. Updated documentation, README, and build configurations to support multiplatform samples, including JS and non-JS targets.

---------

Co-authored-by: Yamil Medina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap/feature Work contributing to adding a new feature as part of the product roadmap. 👕 size: L type: documentation 📋
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants