Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kj/wir 18 reloading wire conversation details #36

Conversation

LennardZieglerCONPORT
Copy link
Collaborator

@LennardZieglerCONPORT LennardZieglerCONPORT commented Jun 26, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Once a meeting has been created in Outlook and Wire Meeting details have been added, the user can remove all mention of the link to the meeting in the location field and in the meeting's description.

If it was a mistake and the user wants to revert it, he can't regenerate the meeting invitation link or details by using the "Add Wire meeting Link" button. It will throw an error stating the meeting is already linked.

Solutions

Reloading Wire conversation details of the already created conversation in a meeting where it has been deleted and setting it again into the appointment.

Dependencies (Optional)

Needs releases with:

  • GitHub link to other pull request

Testing

How to Test

Create an appointment and click "Add a meeting link." After that, delete the location and/or the body from the appointment. Click again on "Add a meeting link." The deleted part of the appointment should be reloaded.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ KevinJaroschewskiCONPORT
❌ kevin.jaroschewski


kevin.jaroschewski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KevinJaroschewskiCONPORT KevinJaroschewskiCONPORT changed the title Kj/wir 18 reloading wire conversation details in a meeting where it Kj/wir 18 reloading wire conversation details Jun 26, 2024
@KevinJaroschewskiCONPORT KevinJaroschewskiCONPORT marked this pull request as ready for review June 26, 2024 08:52
@LennardZieglerCONPORT LennardZieglerCONPORT merged commit 3343147 into staging Jun 26, 2024
4 of 5 checks passed
@LennardZieglerCONPORT LennardZieglerCONPORT deleted the kj/wir-18-reloading-wire-conversation-details-in-a-meeting-where-it branch June 26, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants