Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kj/wir 13 user experience enhancements settings conversation creation #37

Conversation

KevinJaroschewskiCONPORT
Copy link
Collaborator


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

  • "Disconnect Add-in" instead of "Log Out"
  • Name of Conversation should be set to CLDR:: + Meeting picked date or if subject exists CLDR:: {Meeting Name}
  • New Design for Settings Section

Solutions

  • Renamed the Button
  • modifyConversationName, changes the name of the conversation by given details
  • New Design for Settings Section

Testing

How to Test

  • Check the Button on the "Settings" Page
  • Check the /v5/conversations endpoint at the network tab and look at the name attribute
  • Open Settings Tab

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ kevin.jaroschewski
❌ KevinJaroschewskiCONPORT


kevin.jaroschewski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LennardZieglerCONPORT LennardZieglerCONPORT merged commit ca6280b into staging Jul 4, 2024
3 of 4 checks passed
@LennardZieglerCONPORT LennardZieglerCONPORT deleted the kj/wir-13-user-experience-enhancements-settings-conversation-creation branch July 4, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants