-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kj/wir 21 make add in work for outlook mobile #38
Merged
LennardZieglerCONPORT
merged 12 commits into
staging
from
kj/wir-21-make-add-in-work-for-outlook-mobile
Jul 10, 2024
Merged
Kj/wir 21 make add in work for outlook mobile #38
LennardZieglerCONPORT
merged 12 commits into
staging
from
kj/wir-21-make-add-in-work-for-outlook-mobile
Jul 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin.jaroschewski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@LennardZieglerCONPORT I tested it on android and build a workaround. Now it works finally on all platforms. |
LennardZieglerCONPORT
deleted the
kj/wir-21-make-add-in-work-for-outlook-mobile
branch
July 10, 2024 07:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
The Wire outlook add-in failed on mobile
Causes (Optional)
The Wire Outlook add-in failed on mobile because the minimum version requirement for organizer.getAsync is 1.7, but iOS/Android only support up to 1.5.
Solutions
Distinguish between the platforms and get the name of the organizer through the mailbox.userProfile.displayName on mobile devices.
Testing
How to Test
Open the Outlook Add-in on a PC, Android, and iOS device, and check if the meeting link is parsed into the location field and the invitation message is parsed into the appointment body.
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.