Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed slider and classic desktop application #40

Conversation

KevinJaroschewskiCONPORT
Copy link
Collaborator


PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Slider deactivates on mobile after activating it
Add-in is "crashing" on classic outlook desktop after sending the invitation.

Solutions

Fixed the event completion and removed the EventListener from manifest template

How to Test

Create a Meeting Link on Mobile and look at the Wire Slider.
Send a invitation link in outlook classic to check that the outlook add-in does not crash anymore.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kevin.jaroschewski seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LennardZieglerCONPORT LennardZieglerCONPORT merged commit 6a5645d into staging Jul 18, 2024
3 of 4 checks passed
@LennardZieglerCONPORT LennardZieglerCONPORT deleted the kj/wir-21-make-add-in-work-for-outlook-mobile-bugfixes branch July 18, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants