Skip to content

Commit

Permalink
fix: UI bug in E2EI
Browse files Browse the repository at this point in the history
  • Loading branch information
borichellow committed Dec 13, 2023
1 parent c5b8aa5 commit 06140d3
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,11 @@ sealed class UIMessageContent {
Conversation.Protocol.PROTEUS -> R.string.label_system_message_conversation_protocol_changed_proteus
Conversation.Protocol.MIXED -> R.string.label_system_message_conversation_protocol_changed_mixed
Conversation.Protocol.MLS -> R.string.label_system_message_conversation_protocol_changed_mls
},
when (protocol) {
Conversation.Protocol.PROTEUS -> null
Conversation.Protocol.MIXED -> null
Conversation.Protocol.MLS -> R.string.label_system_message_learn_more_about_mls_link

Check warning on line 434 in app/src/main/kotlin/com/wire/android/ui/home/conversations/model/UIMessage.kt

View check run for this annotation

Codecov / codecov/patch

app/src/main/kotlin/com/wire/android/ui/home/conversations/model/UIMessage.kt#L432-L434

Added lines #L432 - L434 were not covered by tests
}
)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import androidx.compose.foundation.layout.padding
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.res.painterResource
Expand Down Expand Up @@ -182,6 +183,7 @@ private fun E2EIStatusRow(
color = labelColor,
)
Image(
modifier = Modifier.align(Alignment.CenterVertically),
painter = painterResource(id = icon),
contentDescription = iconContentDescription,
)
Expand Down
11 changes: 6 additions & 5 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@
<string name="create_account_username_label">USERNAME</string>
<string name="create_account_username_text">Enter your username. It helps others to find you in Wire and connect with you.</string>
<string name="create_account_username_taken_error">This username is already taken. Please choose another one.</string>
<string name="create_account_username_description">At least 2 characters, a-z, 0-9, “_”, “-” and “.”</string>
<string name="create_account_username_description">At least 2 characters, a-z, 0-9 and _</string>
<!-- Conversations -->
<string name="calls_label_missed_calls">MISSED CALLS</string>
<string name="calls_label_calls_history">CALL HISTORY</string>
Expand Down Expand Up @@ -609,7 +609,8 @@
<string name="label_system_message_conversation_history_lost_protocol_changed">You didn\'t update your app in time. Some messages may not appear here.</string>
<string name="label_system_message_conversation_protocol_changed_proteus">Migration of encryption protocol was canceled.</string>
<string name="label_system_message_conversation_protocol_changed_mixed">Migration of encryption protocol has started. Make sure you all your Wire clients are updated.</string>
<string name="label_system_message_conversation_protocol_changed_mls">Migration of encryption protocol is completed. Wire clients which haven\'t been updated will stop receiving messages.</string>
<string name="label_system_message_conversation_protocol_changed_mls">The standard messaging protocol is changing from Proteus to the new Messaging Layer Security (MLS). Learn more about MLS</string>
<string name="label_system_message_learn_more_about_mls_link">https://support.wire.com/hc/en-us/articles/12434725011485-Messaging-Layer-Security-MLS-</string>
<string name="label_system_message_receipt_mode_on">on</string>
<string name="label_system_message_receipt_mode_off">off</string>
<string name="label_system_message_conversation_started_by_self">**You** started the conversation</string>
Expand Down Expand Up @@ -1232,11 +1233,11 @@
<string name="delete_acount_dialog_title">Delete Account</string>
<string name="delete_acount_dialog_text">If you continue, we will send a message via email. Follow the link to permanently delete your account.</string>
<string name="end_to_end_identity_required_dialog_title">End-to-end identity certificate</string>
<string name="end_to_end_identity_required_dialog_text">As of today, your team uses end-to-end identity to make Wire’s usage more secure and practicable. The device verification takes place automatically using a certificate and replaces the previous manual process. This way, you communicate with the highest security standard.\n\nEnter the credentials of your identity provider in the next step to automatically get a verification certificate for this device.</string>
<string name="end_to_end_identity_required_dialog_text_no_snooze">Your team now uses end-to-end identity to make Wire’s usage more secure. The device verification takes place automatically using a certificate.\n\nEnter the credentials of your identity provider in the next step to automatically get a verification certificate for this device.</string>
<string name="end_to_end_identity_required_dialog_text">As of today, your team uses end-to-end identity to make Wire’s usage more secure and practicable.\n\nEnter your identity provider’s credentials in the next step to automatically get a verification certificate for this device.</string>
<string name="end_to_end_identity_required_dialog_text_no_snooze">Your team now uses end-to-end identity to make Wire’s usage more secure.\n\nEnter your identity provider’s credentials in the next step to automatically get a verification certificate for this device.</string>
<string name="end_to_end_identity_required_dialog_positive_button">Get certificate</string>
<string name="end_to_end_identity_required_dialog_snooze_button">Remind me later</string>
<string name="end_to_end_identity_snooze_dialog_text">You can get the certificate in your Wire settings during the next %1$s. Open Devices and select Get Certificate for your current device.\nTo continue using Wire without interruption, retrieve it in time – it doesn’t take long.</string>
<string name="end_to_end_identity_snooze_dialog_text">You can get the certificate in your Wire Settings during the next %1$s.\nOpen Devices and select Get Certificate for your current device. </string>
<string name="end_to_end_identity_renew_dialog_title">Update certificate</string>
<string name="end_to_end_identity_renew_dialog_text">The end-to-end identity certificate for this device expires soon. To keep your communication secure, update your certificate now.\n\nEnter your identity provider’s credentials in the next step to update the certificate automatically.</string>
<string name="end_to_end_identity_renew_dialog_text_no_snooze">The end-to-end identity certificate for this device has expired.\n\nEnter your identity provider’s credentials in the next step to update the certificate automatically.</string>
Expand Down

0 comments on commit 06140d3

Please sign in to comment.