Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed fixed height to adapt to grid view [WPB-5101] #2381

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Oct 27, 2023

BugWPB-5101 [Android] Attachments text are cut


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Attachment item had fixed height which cuts text in some device, so I removed it to adapt to grid view arrangement

@Garzas Garzas requested review from mchenani and saleniuk October 27, 2023 14:21
@Garzas Garzas self-assigned this Oct 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Test Results

659 tests   659 ✔️  5m 18s ⏱️
  96 suites      0 💤
  96 files        0

Results for commit 30a6166.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1569 succeeded.

The build produced the following APK's:

@Garzas Garzas added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 31, 2023
@Garzas Garzas added this pull request to the merge queue Oct 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 31, 2023
@ohassine ohassine added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 1, 2023
@ohassine ohassine enabled auto-merge November 1, 2023 10:11
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2381 (30a6166) into develop (0b2fed5) will increase coverage by 0.00%.
Report is 5 commits behind head on develop.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             develop    #2381   +/-   ##
==========================================
  Coverage      41.49%   41.49%           
  Complexity      1072     1072           
==========================================
  Files            340      340           
  Lines          12187    12189    +2     
  Branches        1604     1604           
==========================================
+ Hits            5057     5058    +1     
  Misses          6650     6650           
- Partials         480      481    +1     
Files Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 65.17% <28.57%> (-0.28%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6aef5d...30a6166. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@ohassine ohassine added this pull request to the merge queue Nov 1, 2023
@AndroidBob
Copy link
Collaborator

Build 1607 succeeded.

The build produced the following APK's:

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@ohassine ohassine added this pull request to the merge queue Nov 1, 2023
Merged via the queue into develop with commit 730d9e6 Nov 1, 2023
11 checks passed
@ohassine ohassine deleted the fix/attachment-fixed-height branch November 1, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants