Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken build #2382

Merged
merged 3 commits into from
Oct 31, 2023
Merged

fix: broken build #2382

merged 3 commits into from
Oct 31, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

e2eiCertificate has been changed to be a suspend function

Solutions

Launch a new coroutine to run that use case

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #2382 (7bc68f7) into develop (0b2fed5) will increase coverage by 0.01%.
The diff coverage is 28.57%.

❗ Current head 7bc68f7 differs from pull request most recent head 48aa179. Consider uploading reports for the commit 48aa179 to get more accurate results

@@              Coverage Diff              @@
##             develop    #2382      +/-   ##
=============================================
+ Coverage      41.49%   41.50%   +0.01%     
  Complexity      1072     1072              
=============================================
  Files            340      340              
  Lines          12187    12186       -1     
  Branches        1604     1603       -1     
=============================================
+ Hits            5057     5058       +1     
+ Misses          6650     6647       -3     
- Partials         480      481       +1     
Files Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 65.17% <28.57%> (-0.28%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b2fed5...48aa179. Read the comment docs.

@ohassine ohassine requested review from a team, yamilmedina, alexandreferris, MohamadJaara, mchenani, Garzas, borichellow and saleniuk and removed request for a team October 30, 2023 10:26
@ohassine ohassine enabled auto-merge October 30, 2023 10:26
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Test Results

659 tests   659 ✔️  10m 1s ⏱️
  96 suites      0 💤
  96 files        0

Results for commit ab02ea6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1584 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2023
@ohassine ohassine added this pull request to the merge queue Oct 30, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 30, 2023
@ohassine ohassine enabled auto-merge October 30, 2023 16:18
@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1590 succeeded.

The build produced the following APK's:

@ohassine ohassine disabled auto-merge October 31, 2023 08:14
@ohassine ohassine enabled auto-merge October 31, 2023 08:14
@ohassine ohassine disabled auto-merge October 31, 2023 08:14
@ohassine ohassine merged commit c340d50 into develop Oct 31, 2023
@ohassine ohassine deleted the fix_broken_build branch October 31, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants