Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update kalium ref #2387

Conversation

AndroidBob
Copy link
Collaborator

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium

What's new in this PR?

Issues

E2EI dialog is shown even when the MLS feature is disabled by feature flag.

Causes (Optional)

Wrong implementation in kalium side

Solutions

Update kalium

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Merging #2387 (1e08805) into develop (a3f34b0) will increase coverage by 0.00%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2387   +/-   ##
==========================================
  Coverage      41.57%   41.58%           
  Complexity      1077     1077           
==========================================
  Files            342      342           
  Lines          12232    12232           
  Branches        1606     1606           
==========================================
+ Hits            5086     5087    +1     
  Misses          6665     6665           
+ Partials         481      480    -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3f34b0...1e08805. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Test Results

661 tests  ±0   661 ✔️ ±0   8m 48s ⏱️ +21s
  97 suites ±0       0 💤 ±0 
  97 files   ±0       0 ±0 

Results for commit 1e08805. ± Comparison against base commit a3f34b0.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@borichellow borichellow closed this Nov 1, 2023
@borichellow
Copy link
Contributor

no need to

@AndroidBob
Copy link
Collaborator Author

Build 1620 succeeded.

The build produced the following APK's:

@yamilmedina yamilmedina deleted the fix/showing_e2ei_dialog_when_feature_disabled-cherry-pick branch April 12, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants