-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(applock): forgot passcode - reset device [WPB-5094] #2392
Conversation
…t-passcode # Conflicts: # app/src/main/kotlin/com/wire/android/ui/home/appLock/unlock/EnterLockCodeScreen.kt
…t-passcode # Conflicts: # app/src/test/kotlin/com/wire/android/ui/home/appLock/SetLockScreenViewModelTest.kt
Test Results674 tests +11 674 ✔️ +11 9m 3s ⏱️ + 1m 42s Results for commit 0dd15ab. ± Comparison against base commit 727c6cf. This pull request removes 2 and adds 13 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Codecov Report
@@ Coverage Diff @@
## develop #2392 +/- ##
=============================================
- Coverage 41.60% 41.57% -0.03%
- Complexity 1077 1078 +1
=============================================
Files 343 344 +1
Lines 12271 12292 +21
Branches 1612 1615 +3
=============================================
+ Hits 5105 5111 +6
- Misses 6685 6699 +14
- Partials 481 482 +1
Continue to review full report in Codecov by Sentry.
|
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1651 succeeded. The build produced the following APK's: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidy
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
When the user forgets the passcode, there needs to be an option to reset it by clearing the whole device.
Solutions
Create new screen that launches when the user clicks on "forgot your passcode?". After clicking on "reset device", the user is asked to enter the password, the app then uses this password and verifies it by executing client removal and if it's successful, then the app makes a hard-logout of all accounts.
Testing
Test Coverage (Optional)
How to Test
Set the applock, kill the app, open again and click on "forgot your passcode?".
Attachments (Optional)
forgot_passlock_reset.mp4
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.