-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: End call on conversation degraded (WPB-4487) #2399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borichellow
requested review from
alexandreferris,
MohamadJaara,
vitorhugods,
mchenani,
ohassine and
saleniuk
November 8, 2023 09:09
borichellow
changed the title
feat: End call on conversation degraded
feat: End call on conversation degraded (WPB-4487)
Nov 8, 2023
Build 1684 failed. |
Build 1685 failed. |
Build 1698 failed. |
Build 1700 failed. |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 1708 succeeded. The build produced the following APK's: |
mchenani
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛡️
yamilmedina
approved these changes
Nov 9, 2023
echoes-hq
bot
added
the
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
label
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes: product-roadmap
Work aligned with the customer-announced roadmap, targeting a specific release date.
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR?
When the conversations verification status (MLS or Proteus) degrades from the "Verified" during the call, call should be ended and user should see the dialog informing him why the call was ended
PS a lot of changes are just imports updates which caused by changes in kalium, donnow why corresponding PR is absent in AR.
Testing
How to Test
For now kalium part works only for the Proteus.
expected result: call is ended and you see the dialog informing that call was ended because of verification changes
expected result: call is ended and you see the dialog informing that call was ended because of verification changes
Attachments (Optional)