Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: End call on conversation degraded (WPB-4487) #2399

Merged
merged 10 commits into from
Nov 9, 2023

Conversation

borichellow
Copy link
Contributor

@borichellow borichellow commented Nov 8, 2023

StoryWPB-4487 [proteus] Show a dialog to explain why a call was ended (conversation degraded status)

What's new in this PR?

When the conversations verification status (MLS or Proteus) degrades from the "Verified" during the call, call should be ended and user should see the dialog informing him why the call was ended

PS a lot of changes are just imports updates which caused by changes in kalium, donnow why corresponding PR is absent in AR.

Testing

How to Test

For now kalium part works only for the Proteus.

  • verify all your devices
  • verify all the devices of some user
  • open the conversation with that user and start a call
  • (without ending a call) un-verify some device of that user

expected result: call is ended and you see the dialog informing that call was ended because of verification changes

  • verify all your devices
  • verify all the devices of some user
  • open the conversation with that user and start a call
  • (without ending a call) un-verify some of your devices

expected result: call is ended and you see the dialog informing that call was ended because of verification changes

Attachments (Optional)

Screenshot 2023-11-08 at 11 05 17

@borichellow borichellow changed the title feat: End call on conversation degraded feat: End call on conversation degraded (WPB-4487) Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Test Results

679 tests  +1   679 ✔️ +1   8m 39s ⏱️ - 3m 57s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit f2b778b. ± Comparison against base commit f666c81.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 1684 failed.

@AndroidBob
Copy link
Collaborator

Build 1685 failed.

@pull-request-size pull-request-size bot added size/M and removed size/L labels Nov 8, 2023
@AndroidBob
Copy link
Collaborator

Build 1698 failed.

@AndroidBob
Copy link
Collaborator

Build 1700 failed.

Copy link
Contributor

github-actions bot commented Nov 8, 2023

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1708 succeeded.

The build produced the following APK's:

Copy link
Contributor

@mchenani mchenani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛡️

@borichellow borichellow added this pull request to the merge queue Nov 9, 2023
Merged via the queue into develop with commit 98659c9 Nov 9, 2023
@borichellow borichellow deleted the feat/end_call_on_conversation_degraded branch November 9, 2023 09:14
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants