fix: Rejoining call can't be completed (WPB-5111)

[ohassine]

WPB-5111 [Android] Join Call - Rejoining call can't be completed

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

After ending a group a call and immediately try to rejoin, a dialog appears saying you are already in a call

Causes (Optional)

After implementing Archive feature, a race condition happened where we are updating the conversationListState from two different places: observeEstablishedCall and search in init block of ConversationListViewModel.
This race condition can lead to wrong state of calling resulting a dialog to appear

Solutions

Create a separate state for calling ConversationListCallState that will be updated on init from one place.

Needs releases with:

• GitHub link to other pull request

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

• Join a group call
• End the call
• Join it again
• You should not the any dialog saying that you are already in a call

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[github-actions]

Test Results

679 tests  ±0   679 ✔️ ±0   8m 57s ⏱️ +28s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ❌ ±0 

Results for commit 5e27759. ± Comparison against base commit 23af8cd.

♻️ This comment has been updated with latest results.

[AndroidBob]

Build 1715 failed.

[AndroidBob]

Build 1716 failed.

[codecov]

Codecov Report

Merging #2407 (5e27759) into develop (23af8cd) will increase coverage by 0.08%.
The diff coverage is 61.64%.

@@              Coverage Diff              @@
##             develop    #2407      +/-   ##
=============================================
+ Coverage      41.46%   41.55%   +0.08%     
+ Complexity      1083     1082       -1     
=============================================
  Files            344      344              
  Lines          12408    12445      +37     
  Branches        1630     1631       +1     
=============================================
+ Hits            5145     5171      +26     
- Misses          6779     6791      +12     
+ Partials         484      483       -1     

Files	Coverage Δ
...id/ui/home/conversationslist/ConversationRouter.kt	0.00% <ø> (ø)
...ui/home/conversationslist/ConversationListState.kt	90.00% <75.00%> (-4.12%)	⬇️
...ome/conversationslist/ConversationListViewModel.kt	59.68% <60.00%> (+1.65%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23af8cd...5e27759. Read the comment docs.

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 1723 succeeded.

The build produced the following APK's:

• com.wire.android-v4.5.0(8057118)(8057118)-staging-compat.apk

[github-actions]

APKs built during tests are available here. Scroll down to Artifacts!

[AndroidBob]

Build 1725 succeeded.

The build produced the following APK's:

• com.wire.android-v4.5.0(8058170)(8058170)-staging-compat.apk