Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(applock): app navigates to biometrics screen after entering passcode #2434

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 16, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

App navigates to biometrics screen after entering valid passcode

Causes (Optional)

We are not clearing biometrics screen from the stack

Solutions

Change back stack mode when navigating to remove current

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from a team, borichellow, vitorhugods, mchenani, Garzas and saleniuk and removed request for a team November 16, 2023 14:43
@saleniuk
Copy link
Contributor

Remember that app lock is now also on release/candidate branch, so we need that fix also there 😉

Copy link
Contributor

Test Results

682 tests  ±0   682 ✔️ ±0   10m 25s ⏱️ + 1m 33s
  98 suites ±0       0 💤 ±0 
  98 files   ±0       0 ±0 

Results for commit aa6c6f7. ± Comparison against base commit 18795b3.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 1858 succeeded.

The build produced the following APK's:

@ohassine ohassine added this pull request to the merge queue Nov 16, 2023
Merged via the queue into develop with commit 547ad8e Nov 16, 2023
18 checks passed
@ohassine ohassine deleted the fix_biometrics_screen branch November 16, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants